-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Issue templates #304
base: develop
Are you sure you want to change the base?
Conversation
Update the templates to reflect the changes made in cisagov/.github#11
blank_issues_enabled: false | ||
contact_links: | ||
- name: 💬 Questions & Help | ||
url: https://github.com/cisagov/.github/blob/develop/QUESTIONS.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a good place to link to this repo's Wiki instead of the generic page:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you two have added useful content, that wiki does not hold a lot of value. Still, a project-specific link or content would make sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could add a link specifically to cisagov/cyhy-system, but I don't think there's much project-specific here to work with right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an entry for the cisagov/cyhy-system Issues page in 948d24f to encourage issue creation for the CyHy environment to happen there instead. Please let me know any thoughts you all might have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the wording to be directive, e.g.:
Create issues in the linked cyhy-system repository except for infrastructure issues with the AMIs, which should be created here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about the config.yml
link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my one comment. Whatever you decide is fine by me, so I'll go ahead and approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this regardless of how the config.yml
discussion ends up. 👍 👍
Issues for this project should be infrastructure- related only. This adds a link to the cisagov/cyhy-system issues page to encourage CyHy environment issues to be created there instead.
🗣 Description
This PR updates the GitHub Issue templates to reflect the updates done to the defaults in cisagov/.github#11.
💭 Motivation and Context
The templates in this repository must be updated manually because we have a custom issue template.
🧪 Testing
Automated tests pass.
✅ Checklist